fix(compiler-cli): emit correct css string escape sequences #22776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around an issue with TypeScript 2.6 and 2.7 that causes the tranformer emit to emit incorrect escapes for css string literals. Fixes: angular#22774
|
You can preview 9942c35 at https://pr22776-9942c35.ngbuilds.io/. |
vicb
approved these changes
Mar 14, 2018
|
You can preview e6b004a at https://pr22776-e6b004a.ngbuilds.io/. |
|
You can preview 752c819 at https://pr22776-752c819.ngbuilds.io/. |
|
You can preview e48718c at https://pr22776-e48718c.ngbuilds.io/. |
vicb
reviewed
Mar 14, 2018
| @@ -150,13 +150,28 @@ function firstAfter<T>(a: T[], predicate: (value: T) => boolean) { | |||
| // NodeEmitterVisitor | |||
| type RecordedNode<T extends ts.Node = ts.Node> = (T & { __recorded: any; }) | null; | |||
|
|
|||
| function escapeLiteral(value: string): string { | |||
| return value.replace(/(\"|\\)/g, '\\$1').replace(/(\n)|(\r)/g, function(v, n, r) { | |||
There was a problem hiding this comment.
would .replace(\n).replace(\r) be more readable ?
vicb
approved these changes
Mar 14, 2018
mhevery
approved these changes
Mar 14, 2018
mhevery
pushed a commit
that referenced
this pull request
Mar 15, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
…22776) Works around an issue with TypeScript 2.6 and 2.7 that causes the tranformer emit to emit incorrect escapes for css string literals. Fixes: angular#22774 PR Close angular#22776
thymikee
pushed a commit
to thymikee/jest-preset-angular
that referenced
this pull request
Aug 4, 2018
- Upgrade example app to `Angular` v6.1 with `TypeScript` v2.9. - Upgrade `jest` and `jest-preset-angular` to reflect the latest support of `jest` v23. - Upgrade snapshot of `AppComponent` due to the [change](angular/angular#22776) in `Angular` v6.1. - Upgrade other dependencies.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around an issue with TypeScript 2.6 and 2.7 that causes
the tranformer emit to emit incorrect escapes for css string
literals.
Fixes: #22774
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #22774
What is the new behavior?
Bypasses TypeScript incorrect string escaping to produce the correct
.jsfile.Does this PR introduce a breaking change?